Arcs, segments, and sectors #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canvas gets several new calls: `setLinePattern` accepts a LinePattern object for setting a pattern a line can optionally use `setLinePatternLength` allows the length of the line pattern to be set `setLinePatternOffset` allows the offset within the pattern to be adjusted `setLineOptions` sets whether a line should be drawn as a dotted line, and whether its first and/or last points should be omitted BitmappedDisplayController’s `PaintState` object now includes `linePattern`, `lineOptions` and `linePatternLength`. `genericAbsDrawLine` now looks at the `lineOptions` in the current paint state to determine whether a dotted line should be drawn, and whether first or last points should be omitted fabutils gains a `getBit` function which will get a bit at an index within an array of uint8_t numbers. the position is in “most significant bit” order, i.e. bitIndex 0 is the bit representing 128 in the first byte in the array
basic arc support for all screen depths NB there is no compensation in these for non-square pixel modes, i.e. the circle that arc follows assumes squareness
adds the ability to draw filled segments builds on work to draw arcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for drawing arcs, filled segments and filled sectors
Parameters for these functions essentially match the style of Acorn's equivalent PLOT calls
also includes code from #39
for clarity of the git commit history I'd recommend merging using a merge commit rather than using a "squash". the commits in this PR individually add functionality for each new feature