Fix Optional deserialization of null - #566
Merged
Merged
Conversation
SentryMan
previously approved these changes
Aug 12, 2026
SentryMan
approved these changes
Aug 15, 2026
Contributor
|
@rbygrave have you anything to add? |
rbygrave
approved these changes
Aug 18, 2026
Contributor
|
3.15-RC5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
serializeNullsis set to true, an empty Optional would be serialized as JSONnull, but deserialized as Javanullinstead of an empty Optional. While both Javanulland empty Optional map onto JSONnull, I think the vast majority of use cases would want to use an empty Optional overnull. This changes the deserialization of Optionals to recognizenulland return an empty Optional.