Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

Why this should be merged

Replaces native minter e2e hardhat tests with golang bindings and a simulated backend test.

Part of #1228

How this works

Generates relevant golang bindings from sol files for the testing. Mirrors the hardhat test to a golang test using simulated backend.

How this was tested

CI

Need to be documented?

No

Need to update RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer self-assigned this Nov 21, 2025
@JonathanOppenheimer JonathanOppenheimer added ci testing This primarly focuses on testing labels Nov 21, 2025
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/convert-native-minter-test branch from a93e2b6 to b7eec85 Compare November 21, 2025 20:59
@JonathanOppenheimer JonathanOppenheimer force-pushed the JonathanOppenheimer/convert-native-minter-test branch from 4131d69 to ef32f2f Compare November 21, 2025 21:11
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review November 21, 2025 21:47
@JonathanOppenheimer JonathanOppenheimer requested review from a team and maru-ava as code owners November 21, 2025 21:47
@JonathanOppenheimer JonathanOppenheimer changed the title feat: convert native minter test to go framework feat: convert native minter npm test to go test Nov 21, 2025
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it's looking good. We just need to the helper file and decide the test structure in #1878

ceyonur
ceyonur previously requested changes Dec 1, 2025
@ceyonur ceyonur added this pull request to the merge queue Dec 1, 2025
Merged via the queue into master with commit 7b6dad8 Dec 1, 2025
13 checks passed
@ceyonur ceyonur deleted the JonathanOppenheimer/convert-native-minter-test branch December 1, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci testing This primarly focuses on testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants