CP-9698: Portfolio assets screen #2256
Open
+1,225
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruijialin-avalabs
requested review from
neven-s,
atn4z7 and
onghwan
as code owners
| n: Network | ||
| ): React.JSX.Element | undefined => { | ||
| if (t.localId === AVAX_X_ID) { | ||
| return isDark ? ( |
There was a problem hiding this comment.
decided to still go with using local svg to render x/p network logo to meet the dark theme design requirement.
| balance => balance.dataAccurate === true | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
this is used to show error state if all balances is inaccurate.
| @@ -104,16 +104,14 @@ export const Button = forwardRef< | |||
| alignItems: 'center', | |||
There was a problem hiding this comment.
this Button will be updated after Junghwan merged his PR.
ruijialin-avalabs
force-pushed
the
cp-9698
branch
from
9013d81 to
cd16052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9704
Screenshots/Videos
Screen.Recording.2025-02-10.at.12.11.01.PM.mov
Screen.Recording.2025-02-10.at.3.00.52.PM.mov
Checklist
Please check all that apply (if applicable)