Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-9448: Upgrade to React Native 0.76.2 and Expo SDK 52 #2187

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

CP-9448: Upgrade to React Native 0.76.2 and Expo SDK 52 #2187

wants to merge 47 commits into from

Conversation

onghwan
Copy link
Contributor

@onghwan onghwan commented Jan 10, 2025 •
edited
Loading

Description

Ticket: CP-9448

  • React Native 0.76.2
  • Expo SDK 52.0.9
  • Modern Architecture Enabled
  • Hermes JavaScript Engine
  • Dependency Updates
  • Updated iOS and Android native configurations to meet the requirements of the new architecture.

Notes

  • I recommend updating Android Studio for the build. It has been confirmed to work well with the Ladybug version.
  • If you’d like to build it locally, I recommend doing a clean build.
// in packages/core-mobile
> ../../scripts/remove-node-modules.sh
> yarn install
> yarn setup

// for iOS
> rm -rf ./ios/Pods/
> yarn podInstall
> yarn ios

// for Android
> ./android/gradlew clean
> yarn android

Testing

No new features have been added, but regression testing is required.

Checklist

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@onghwan onghwan force-pushed the CP-9448 branch 3 times, most recently from 70dfb5b to 9097df3 Compare January 17, 2025 15:48
@onghwan onghwan changed the title CP-9448: upgrade react native and expo CP-9448: Upgrade to React Native 0.76.2 and Expo SDK 52 Jan 18, 2025
@onghwan onghwan marked this pull request as ready for review January 21, 2025 13:50
@onghwan onghwan marked this pull request as draft January 21, 2025 15:29
@ava-labs ava-labs deleted a comment from semgrep-code-ava-labs bot Jan 22, 2025
@onghwan onghwan marked this pull request as ready for review January 22, 2025 07:37
ruijialin-avalabs
ruijialin-avalabs reviewed Jan 24, 2025
View reviewed changes
packages/core-mobile/app/store/transforms/EncryptThenMacTransform.ts Outdated
DECRYPT_INPUT_ENCODING,
UTF8
)
// @ts-ignore
const cleartext = (buffer + decipher.final(UTF8)).toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can make sure buffer is typeof string instead of doing ts-ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@onghwan onghwan force-pushed the CP-9448 branch 3 times, most recently from e6c1a0f to b74b8a1 Compare January 28, 2025 03:25
atn4z7
atn4z7 reviewed Jan 28, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
atn4z7
atn4z7 reviewed Jan 28, 2025
View reviewed changes
packages/core-mobile/app/components/QrScannerAva.tsx
Comment on lines -4 to +8
import { BarCodeReadEvent } from 'react-native-camera'
import { useApplicationContext } from 'contexts/ApplicationContext'
import {
BarcodeScanningResult,
CameraView,
useCameraPermissions
} from 'expo-camera'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice replacement for camera!

atn4z7
atn4z7 reviewed Jan 28, 2025
View reviewed changes
packages/core-mobile/app/seedless/services/wallet/SeedlessWallet.ts
@@ -358,6 +358,6 @@ export default class SeedlessWallet implements Wallet {
),
'hex'
)
return utils.base58check.encode(buffer)
return utils.base58check.encode(new Uint8Array(buffer))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure QA test all signing again

atn4z7
atn4z7 reviewed Jan 28, 2025
View reviewed changes
packages/core-mobile/ios/.xcode.env Outdated
export SENTRY_DISABLE_AUTO_UPLOAD=true # Temporarily disable source map upload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is something wrong with source map upload?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When auto-upload is enabled, it seems to automatically upload sourcemap even in debug mode. That’s why it’s stated in the documentation to disable it.

https://docs.sentry.io/platforms/react-native/manual-setup/manual-setup/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto upload enabled.

onghwan added 27 commits February 10, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn4z7 atn4z7 atn4z7 left review comments

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onghwan @atn4z7 @ruijialin-avalabs