[tmpnet] Deploy collectors with golang to simplify cross-repo use #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
added
testing
maru-ava
force-pushed
the
tmpnet-managed-collectors
branch
from
b92d89b to
59e5357
Compare
Previously, prometheus and promtail were installed and launched by with bash scripts. Migrating installation to nix and launch to golang enables directly sharing the functionality with subnet-evm and hypersdk. No more having to copy and maintain copies of the scripts in multiple repos.
maru-ava
force-pushed
the
tmpnet-managed-collectors
branch
from
59e5357 to
15c496b
Compare
This was referenced Feb 2, 2025
Comment on lines
+182
to
+184
| // TODO(marun) Figure out a way to redirect stdout and stderr of a detached child process without a bash shell | ||
| cmd := exec.Command("bash", "-c", fullCmd) | ||
| configureDetachedProcess(cmd) // Ensure the child process will outlive its parent |
There was a problem hiding this comment.
I believe you can create the command and set Stdout and Stderr to nil directly (according to the docs)
There was a problem hiding this comment.
Please give it a try and get back to me, because my attempts to create a child process that outlives its parent and configured with stdout and stderr redirected to a file created and opened by that parent were entirely unsuccessful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, prometheus and promtail were installed and launched by with bash scripts. Migrating installation to nix and launch to golang enables directly sharing the functionality with subnet-evm and hypersdk. No more having to copy and maintain copies of the scripts in multiple repos.
How this works
--enable-collectorsHow this was tested
Need to be documented in RELEASES.md?
N/A
TODO