Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change/range proofs + simplify the code #3688

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rrazvan1
Copy link
Contributor

@rrazvan1 rrazvan1 commented Jan 31, 2025

Why this should be merged

Fixing proof verification bugs:

  1. exclusion proofs -> passing when providing a wrong replacement child
  2. exclusion proofs -> passing when providing not fully extended proof
    This issues were mainly affecting the simple proofs verification, but also change/range proofs.

And also, simplifying the code for a better readability.

How this works

  • moving the main logic of proofs validation inside verifyProofPath(proofPath []ProofNode, key Key) and simplifying the specific proof verifications.
  • added new specific errors
  • more details within comments

How this was tested

UTs

Need to be documented in RELEASES.md?

@rrazvan1 rrazvan1 marked this pull request as draft January 31, 2025 13:39
@rrazvan1 rrazvan1 force-pushed the fix-proof-verification branch from a296faa to 8d0dafd Compare January 31, 2025 14:08
@rrazvan1 rrazvan1 force-pushed the fix-proof-verification branch from 33e69e1 to 923f088 Compare February 3, 2025 14:20
@rrazvan1 rrazvan1 marked this pull request as ready for review February 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 🗄️
Development

Successfully merging this pull request may close these issues.

1 participant