fix(localization): remove duplicated config files - #1054
sasakisasaki merged 9 commits into
Conversation
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 60.79% 54.06% -6.74%
==========================================
Files 433 401 -32
Lines 25821 24334 -1487
Branches 12257 11028 -1229
==========================================
- Hits 15698 13155 -2543
- Misses 7134 9747 +2613
+ Partials 2989 1432 -1557
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* We can trace that the change is derived from here:
- https://github.com/autowarefoundation/autoware_core/pull/1054/changes#diff-74292a33fd9e2f1bb16981050ebc0f61cff9abd1f50dde3be6424c3f989f854bL4-L5
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Until this commit, some parameters such as `ekf_enabled`, `gnss_enabled`, ... etc are not passed.
It seems we were using the hard-coded values in the previous `pose_initializer.param.yaml`.
So applied fixes to:
* Pass pose initializer flags via launch include
* Add defaults and bool params in pose initializer launch
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…low)
* Followed a way that of `autowarefoundation/autoware_launch`
- https://github.com/autowarefoundation/autoware_launch/blob/6b71b90f3a1fd07c08defe974c7caff917759108/tier4_universe_launch/tier4_localization_launch/launch/pose_twist_estimator/pose_twist_estimator.launch.xml#L26-L29
* This commit reverts the hard-coded values in the following commit
- autowarefoundation@da904d6
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
fc0bba4 to
61757f3
Compare
xmfcx
left a comment
There was a problem hiding this comment.
Direction looks right.
5 of 6 configs were either byte-identical to upstream or trivially aligned (EKF only gains the new diagnostics_publish_frequency: 10.0).
The <include>-of-upstream pattern matches what tier4_universe_launch already does.
Approving, with two items to address in a follow-up PR. Please prioritize that follow-up, ideally before the next release branch is cut.
1. voxel_grid_downsample_filter_node will crash at startup on this launch path.
You already saw and documented this.
The deleted autoware_core_localization/config/voxel_grid_downsample_filter.param.yaml was the only thing supplying input_frame / output_frame.
Upstream sensing/autoware_downsample_filters/config/voxel_grid_downsample_filter_node.param.yaml does not define them.
The node constructor at voxel_grid_downsample_filter_node.cpp:41-42 calls declare_parameter<std::string>(\"input_frame\") with no default, so it throws ParameterUninitializedException.
Inlining the <node> at autoware_core_localization.launch.xml:18-22 bypasses the upstream launch wrapper that would otherwise inject those frames.
Easiest fix in the follow-up: swap the inlined <node> for an <include> of \$(find-pkg-share autoware_downsample_filters)/launch/voxel_grid_downsample_filter_node.launch.xml.
That wrapper already defaults input_frame / output_frame to base_link, and matches how every other upstream launch is brought in by this file.
Until that lands, anyone launching autoware_core_localization.launch.xml outside is_planning_simulation:=true mode hits this crash. Please don't let the follow-up sit.
2. voxel_size_* silently changes from 3.0 m to 1.5 m.
Output density rises roughly 8x, and NDT input cost changes with it.
Whichever value is intended for the core profile, please call it out in the follow-up PR's description so it is not a silent tuning change.
Nice cleanup otherwise. Happy to see the duplication go.
|
@mitsudome-r Could you kindly review this PR please? 🙏 |
localization): remove duplicated config fileslocalization): remove duplicated config files
…nfig-files-in-localization Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…f github.com:sasakisasaki/autoware.core into chore-remove-duplicated-config-files-in-localization Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
|
Tick the box to add this pull request to the merge queue (same as
|
Description
Remove the
autoware_core_localization/configfolder as it contains duplicated files which are existing in the following path:$(find-pkg-share autoware_ekf_localizer)/config/ekf_localizer.param.yaml$(find-pkg-share autoware_stop_filter)/config/stop_filter.param.yaml$(find-pkg-share autoware_twist2accel)/config/twist2accel.param.yaml$(find-pkg-share autoware_pose_initializer)/config/pose_initializer.param.yaml$(find-pkg-share autoware_downsample_filters)/config/voxel_grid_downsample_filter_node.param.yaml$(find-pkg-share autoware_ndt_scan_matcher)/config/ndt_scan_matcher.param.yamlRelated links
How was this PR tested?
We will use the planning simulation for runtime check. As the tests are done, we will make this PR as "Ready for review".=> Tests are done 👍
Steps for tests
autoware_corewith this PR's branch$ git clone -b chore-remove-duplicated-config-files-in-localization git@github.com:sasakisasaki/autoware.core.git $ cd autoware_corecore.reposwith the following contentsvcs import$ mkdir src $ vcs import src < core.reposcolcon buildautoware_core. Download autoware_core.patch then,$ patch -p1 < autoware_core.patchis_planning_simulation:=true. We use two terminals:Then set the initial pose and goal pose as the attached video
Screencast from 2026-04-28 20:13:40.webm
Enable autonomous mode and switch to DRIVE gear
You will see the ego vehicle start running as the attached video.
is_planning_simulation:=true. I verified all the localization modules are launched without any error.Conclusion for Tests
From these observation, I judged we can launch all the localization modules by this PR.
Notes for reviewers
The config files under the
autoware_core_localization/configsometimes contains out-of-date parameters which are not used in the code. This PR will remove the duplicated files and make sure that the config files are up-to-date.Interface changes
Effects on system behavior
If anybody is using the config files under the
autoware_core_localization/configfolder, they need to change the path to the config files in their launch files. The new path should be as written in the description section.