feat(ansible): add the CARLA 0.10 Town10HD_Opt map to demo_artifacts - #7308
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c078bb7625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I thought you were going to include kashiwanoha map in this pack. And remove the kashiwanoha entry. Did you change your mind? |
No change of mind — the plan is still to fold Kashiwanoha into carla-ue5-maps and drop the map-carla-kashiwanoha entry. It just isn’t ready yet. |
The Autoware maps published alongside the CARLA towns were recorded on CARLA 0.9. CARLA 0.10 re-authored those towns in Unreal Engine 5, so the published point clouds no longer describe the world a vehicle drives in, and NDT matches against them are wrong wherever the geometry moved. The AutowareFoundation/carla-ue5-maps dataset carries point clouds recorded from 0.10 itself, one directory per world, starting with Town10HD_Opt. The download joins the hf loop the Kashiwanoha map already runs in, as that commit anticipated. Two changes make room for it: the filters are per entry now, because this dataset drops preview renders and unwanted worlds rather than a video, and dest is relative to autoware_data instead of maps, because the dataset already namespaces its worlds under autoware_maps/ and hf keeps that prefix - so it unpacks into maps/ rather than claiming a directory of its own. The Kashiwanoha download is byte-identical after the change. The dataset carries no tag yet, so the revision is the commit that published Town10HD_Opt. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lb99yovCQZVXT47PYzAjXJ Signed-off-by: Atrium Coding Agent <agent@atrium.local>
The role's README linked the CARLA demo and said the towns are used "on CARLA 0.10", but that demo pins 0.9.16 for both the simulator image and the Python API. A reader who followed the link and set map_path to Town10HD_Opt would pair a 0.10 point cloud with 0.9 town geometry - the mismatch the same paragraph warns about, only in the other direction. Drop the claim, and add a section to the demo README that says what raising the pin would take: there is no CARLA 0.10 client wheel on PyPI or in the 0.10.0 release, and autoware_carla_interface is still on the 0.9 pedal map and vehicle catalogue. The simulator image carlasim/carla:0.10.0 does exist, so it is the client and the bridge that are missing, not the server. The maps are still downloaded unconditionally - 24 MB of data published ahead of the runtime that reads it is cheaper to have than to gate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lb99yovCQZVXT47PYzAjXJ Signed-off-by: Atrium Coding Agent <agent@atrium.local>
b507fb4 to
e0c4980
Compare
| │ ├── autoware_maps/ | ||
| │ │ └── Town10HD_Opt/ |
There was a problem hiding this comment.
I realized that this is wrong after merging it, @hakuturu583 -san could you fix it?
| │ ├── autoware_maps/ | |
| │ │ └── Town10HD_Opt/ | |
| │ ├── Town10HD_Opt |
Description
The Autoware maps published alongside the CARLA towns were recorded on CARLA 0.9. CARLA 0.10 re-authored those towns in Unreal Engine 5, so the published point clouds no longer describe the world a vehicle drives in, and NDT scores a confident match on geometry that has moved.
AutowareFoundation/carla-ue5-mapscarries point clouds recorded from 0.10 itself, one directory per world, starting withTown10HD_Opt.This adds that download to
demo_artifacts, joining thehfloop the Kashiwanoha map already runs in — as #7301 anticipated ("the next map dataset is one more loop entry"). Two changes make room for it:--exclude "*.mp4"that dropped the Kashiwanoha demo video was hardcoded; entries now carryinclude/excludepattern lists. This dataset drops the preview renders and every world butTown10HD_Opt.destis relative toautoware_data, notmaps. The dataset already namespaces its worlds underautoware_maps/, andhf downloadpreserves the repo-relative path, so this entry pointsdestatmapsitself and unpacks intomaps/autoware_maps/Town10HD_Opt/rather than claiming a directory of its own. That is the layout the dataset card documents, and the directory basename is the world name CARLA loads, matching themap_pathconvention the CARLA demo already uses.The Kashiwanoha download is unchanged — same argv before and after.
The dataset carries no tag yet, so the revision is the commit that published
Town10HD_Opt(682ddd4).Resulting layout:
Adding a world later is one more
includepattern.How was this PR tested?
Rendered the templated
hfcommand through Ansible's own Jinja (ansible-playbookover the task'sloopandloop_control) and compared the argv aftershlexsplitting. Themap-carla-kashiwanohainvocation is byte-identical tomain; the new one is:Ran that command for real against a scratch
--local-dir. It fetches exactly the three map files at the pinned revision, no preview renders:map_projector_info.yamlisprojector_type: Local, and the point cloud header reports the 1 851 689 points the dataset card states.pre-commit run --files ansible/roles/demo_artifacts/{tasks/main.yaml,README.md}passes (yamllint,prettier,markdownlint,check-yaml).Not exercised: a full
ansible-playbook autoware.dev_env.install_dev_env --tags demo_artifactsrun —demo_artifactsisnever-tagged and not covered byhealth-check-ansible, so the role was verified at the task level as above rather than end to end.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lb99yovCQZVXT47PYzAjXJ