Set has android dependencies weight to 100 #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents "should be jvm" advice for projects that cannot be since they have android dependencies.
joshfriend
force-pushed
the
jfriend/android-dependency-score
branch
from
79fe843 to
3c43d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents "should be jvm" advice for projects that cannot be since they have android dependencies.
@autonomousapps and I chatted on slack about it and for now decided to try fixing most of the issues by setting the weight of using android dependencies to 100 so that any module with android deps never gives the "should be jvm" advice
see also #1417