Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify McNemar #12

Merged
merged 5 commits into from
Apr 13, 2021
Merged

clarify McNemar #12

merged 5 commits into from
Apr 13, 2021

Conversation

larskotthoff
Copy link
Contributor

Follow up to #6 -- @berndbischl please have a look.

@berndbischl
Copy link
Contributor

this still is wrong?

\item can be applied to compare the performance of two \textbf{models}
    when the considered performance measure is based on an outer loss with a
    nominal or binary output, e.g.\ accuracy is based on a binary outer loss

the test doesn't refer to any specific measure? you could argue it tests for accuracy, but that's not "e.g." then

@berndbischl
Copy link
Contributor

you also dont test that B=C, as these are absolute values, but that the cell proportions are the same?

@larskotthoff
Copy link
Contributor Author

Not sure if I get your point. How would you rephrase?

@mlindauer
Copy link
Collaborator

@berndbischl could you please look into this again s.t. we can merge this soon. Lars is blocked to record again this video without having the fixed slides.

@mlindauer
Copy link
Collaborator

@ludwig-max @jakob-r can you two somehow comment on the problem on the slides or even fix these?

@jakob-r
Copy link
Collaborator

jakob-r commented Mar 19, 2021

I corrected the part @berndbischl mentioned and double-checked the surroundings. From my side it can be merged.

@mlindauer
Copy link
Collaborator

@larskotthoff If you are also happy with the changes, could you please record the videos (in particular the few seconds in the beginning) as soon as possible? We have to deliver the AutoML course soonish, best would be before the new semester starts mid of April. Please take into consideration that also uploading the new videos takes a few days (because the ki-campus has to do it).

@larskotthoff
Copy link
Contributor Author

Thanks, I've fixed a few typos and requested @berndbischl have a look at it.

@larskotthoff larskotthoff merged commit fdb58e8 into master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants