-
Notifications
You must be signed in to change notification settings - Fork 34
fix: add Vale linting [DM-4] #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mikemimik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 The output of the vale action is a little different than I expected. I thought that it would be similar to the terminal output you showed me @darrickyong when implementing this. My expectation was that the action would fail, not pass, and I'm curious why that is.
hazel-nut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move the vale config back to the a4aa directory while it's only applying to a4aa docs. the github action is handy! have you looked into using reviewdog to leave inline PR comments?
| - uses: errata-ai/[email protected] | ||
| with: | ||
| files: '["auth4genai/"]' | ||
| fail_on_error: true | ||
| filter_mode: nofilter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set this to run only on the files that are changed in the PR?
| ## Vale Linting | ||
|
|
||
| We use [Vale](https://vale.sh/) to keep terminology and brand usage consistent across the docs. See the dedicated Vale guide in [`./.vale/README.md`](./.vale/README.md) for details on configuration structure, MDX support, and how to extend or adjust the rules. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this from here + restore it in the a4aa README
| # Vale Linting | ||
|
|
||
| This directory contains the Vale configuration used to lint and standardize the documentation in `auth4genai`. Vale helps ensure consistent terminology, brand usage, spelling, and overall prose quality. | ||
| This directory contains the Vale configuration used to lint and standardize the documentation in `docs-v2`. Vale helps ensure consistent terminology, brand usage, spelling, and overall prose quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should revert this
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR adds
valeas a Github Action and initialvaleconfig.References
Testing
Checklist