Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Update a Custom Domain #763

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

kailash-b
Copy link
Contributor

@kailash-b kailash-b commented Jan 9, 2025

Changes

Please describe both what is changing and why this is important. Include:

References

Please include relevant links supporting this change such as a:

Testing

Tests for custom domains are limited. We cannot test full CRUD sequence because the tenants allow for only one custom domain and others depend on that domain.
We are therefore limited in scope to what we can test.
For now, we have updated the test that we run manually to verify that the basic serialization and the GET methods work properly.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner January 9, 2025 09:33
@kailash-b kailash-b force-pushed the feature/SDK-5495-CustomDomains branch from d2a4544 to a11bd86 Compare January 15, 2025 04:00
@kailash-b kailash-b force-pushed the feature/SDK-5495-CustomDomains branch from a11bd86 to 62fdfe9 Compare January 15, 2025 05:18
@kailash-b kailash-b force-pushed the feature/SDK-5495-CustomDomains branch from 62fdfe9 to 3d4eef0 Compare January 15, 2025 05:20
@kailash-b kailash-b merged commit 40ea87f into master Jan 15, 2025
11 checks passed
@kailash-b kailash-b deleted the feature/SDK-5495-CustomDomains branch January 15, 2025 06:01
@kailash-b kailash-b mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants