refactor(react): remove any in test cases #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Preview deploymentBranch: 📝 Preview URL: https://auth0-universal-components-7g9p702ia-okta.vercel.app Updated at 2025-12-19T05:47:20.494Z |
Base automatically changed from
refactor/fix-org-translations
to
feat/rename-org-in-react-package
December 24, 2025 07:38
Base automatically changed from
feat/rename-org-in-react-package
to
feat/rename-org-to-organization
December 24, 2025 07:49
rax7389
requested changes
Jan 6, 2026
Comment on lines
+19
to
+20
| const mockMyOrganizationClient = mockCoreClient.getMyOrganizationApiClient(); | ||
| mockMyOrganizationClient.organization.configuration.get = mockGet; |
Contributor
There was a problem hiding this comment.
Im not entirely sure this override is necessary, as we aren't providing a specific response during the mock phase. Could you please double check if this is required?
Comment on lines
+84
to
+102
| const createCustomMockTranslator = (): ReturnType< | ||
| typeof useTranslatorModule.useTranslator | ||
| >['t'] => { | ||
| const translatorFn = vi.fn((key: string, params?: Record<string, unknown>) => { | ||
| if (key === 'general_error') return 'An error occurred'; | ||
| if (key === 'update_success') return `Updated ${params?.providerName || ''}`; | ||
| if (key === 'delete_success') return `Deleted ${params?.providerName || ''}`; | ||
| if (key === 'remove_success') | ||
| return `Removed ${params?.providerName || ''} from ${params?.organizationName || ''}`; | ||
| return key; | ||
| }); | ||
|
|
||
| // Add trans method for EnhancedTranslationFunction compatibility | ||
| const translator = Object.assign(translatorFn, { | ||
| trans: vi.fn(() => []), | ||
| }); | ||
|
|
||
| return translator as ReturnType<typeof useTranslatorModule.useTranslator>['t']; | ||
| }; |
Contributor
There was a problem hiding this comment.
can we try to use the existing mock translator test utility createMockI18nService?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Remove any casting in test cases and add correct types
References
https://auth0.slack.com/archives/C09DNSP8U0Z/p1766047059411379
Testing
All Tests should pass
Checklist