Skip to content

Conversation

@kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Aug 7, 2025

🔧 Changes

Add new badge to the README.md and updates the CustomDomainsHadnler class to improve how custom domain fields are handled during create and update operations. The main focus is on ensuring that certain metadata fields are stripped out when creating or updating custom domains, which helps prevent errors and keeps the payloads clean.

Custom Domains handler improvements:

  • Updated the stripCreateFields in CustomDomainsHadnler to also remove created_at and updated_at fields when creating custom domains, preventing unintended metadata from being sent.
  • Updated the stripUpdateFields to also remove created_at and updated_at fields when updating custom domains, ensuring consistency and avoiding update errors.

📚 References

🔬 Testing

Test passing ✅

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 requested a review from a team as a code owner August 7, 2025 08:30
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (3b8cadf) to head (856ee3f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files         131      131           
  Lines        4980     4980           
  Branches      983      983           
=======================================
  Hits         4000     4000           
  Misses        564      564           
  Partials      416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 merged commit c519a9e into master Aug 7, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the fix-deploy-customDomains branch August 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants