This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Ignore VTK version when verifying test results #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf1a796.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
Contributor
|
Nice fix! I'd probably prefer this to be added on the MOOSE side, since it's in our interest to pin the MFEM version here anyway as we move towards archiving this repo following the migration. |
Collaborator
Author
|
Superseded by idaholab/moose#30485. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to #92 for the test failures caused by the VTK version change.
Mostly for information and future reference, feel free to close if not worth it in this repo.
Happy to apply this patch on the MOOSE side instead if deemed appropriate.