feat(skills): land audit-rule-author skill (rule + agentic-audit authoring)#155
Open
anmolg1997 wants to merge 1 commit into
Open
feat(skills): land audit-rule-author skill (rule + agentic-audit authoring)#155anmolg1997 wants to merge 1 commit into
anmolg1997 wants to merge 1 commit into
Conversation
…oring) Akhilesh's audit-rule-author Claude Code skill, brought over from the evidence-synthesis branch. It guides authoring/maintaining compliance audit rule config (backend/app/compliance/rules/), including the agentic_audit strategy guide (target/context design, pass_criteria patterns, postpass validation) — the agentic-audit authoring guidance we had been waiting on. All infra it references (validate_cli, registry, profiles, document_profiles, run_checklist_agentic_postpass, the agentic stack) is already on main, so the skill is self-contained. Main-compat adaptations (the only changes to the original): - peek_pages.py: read segmentation.json (page-range DocumentSection) instead of the nonexistent per-page classification.yaml; legacy classification.yaml kept as a fallback. Verified --list-sections renders real sections on main. - both scripts: honor AT_STORAGE__BASE_PATH (the pipeline's own storage var) and add --data-root to peek_pages, instead of only the hardcoded cwd-relative path. - SKILL.md data-location section updated to match (segmentation.json + storage root). Follow-ups for the author (non-blocking, documented in the PR): tighten the description's broad triggers; caveat that validate_cli evaluates text_primary/llm_arbitrated as text-only.
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands Akhilesh's
audit-rule-authorClaude Code skill (authored on theevidence-synthesisbranch) into.claude/skills/. This is the rule-authoring skill — and the agentic-audit authoring guidance — we had been waiting on.The skill helps author/maintain compliance audit rule config (
backend/app/compliance/rules/):VC-*visual-check tags, merge-behavior reference, preflight checklist.agentic_auditstrategy guide: target/context section design,context_sources, pass_criteria patterns (signature images, summary-vs-subrow tables, NOT_APPLICABLE thresholds, exclusion counter-examples), postpass validation.peek_pages.py(OCR + section inspection),analyze_results.py(filtercompliance_result.json). evals/ — 3 triggering/behavior evals.Self-contained against main
All infra the skill references is already merged:
validate_cli,registry,profiles,document_profiles.yaml,run_checklist_agentic_postpass.py, and theapp/compliance/agentic/stack. No dependency on the rest ofevidence-synthesis(that branch's ~1,600-line rules/segmentation/report changes are a separate review and are intentionally not included here).Review + main-compat fixes
An independent skill review (plugin-dev:skill-reviewer) found it high-quality and self-contained, with one real drift against main, which I fixed (the only changes to the original):
peek_pages.pyread a per-pageclassification.yamlthat doesn't exist on main (the pipeline writessegmentation.json, page-rangeDocumentSection). Rewrote the loader to readsegmentation.json(legacyclassification.yamlkept as fallback). Verified--list-sectionsrenders real sections on a live doc.AT_STORAGE__BASE_PATH(the pipeline's own storage var) andpeek_pages.pygained--data-root, instead of only the hardcodedbackend/data/documentscwd path.Follow-ups for the author (non-blocking)
"analyze results","look at findings") — could over-trigger; worth scoping.text_primary/llm_arbitratedundervalidate_cli, butvalidate_clievaluates those text-only (doesn't run the escalate/arbitrate merge) — worth a caveat.Testing
py_compileclean;peek_pages.py --list-sectionssmoke-tested against a real doc → correct page-range sections. Skill auto-discovered by the harness (valid structure).