Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react component in Aurelia 2 #8

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

react component in Aurelia 2 #8

wants to merge 21 commits into from

Conversation

danice
Copy link
Contributor

@danice danice commented May 28, 2023

This is how-to-use-react-js-in-aurelia updated to Aurelia 2.

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
advanced-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
animation-native ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-attribute-patterns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-crypto-tracker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-emotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-examples-showcase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-lamba-expressions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-lambda-expressions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-shadow-dom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-state ❌ Failed (Inspect) Jun 21, 2023 6:35am
aurelia2-state-persistence ❌ Failed (Inspect) Jun 21, 2023 6:35am
aurelia2-tailwind ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
aurelia2-validation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
metronome-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
qr-creator-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
simple-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
using-watch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am
widget-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:35am

@Vheissu
Copy link
Member

Vheissu commented Jun 21, 2023

Looking good @danice just one question. I noticed you updated the docs to use pnpm instead of npm. Just wondering if there was a specific reason?

@danice
Copy link
Contributor Author

danice commented Jun 21, 2023

I was preparing a separate PR for this but I think github has merged to my existing PR without me noticing...

@danice
Copy link
Contributor Author

danice commented Jun 21, 2023

I have updated the examples to work with last version of aurelia (some I was not able to make it work, it's indicated in commit message)
If I'm not wrong, here each example is independent from the others and the monorepo structure was used just to avoid space in node_modules. This can more easily get using pnpm, that has also the following advantatges:

  • it has better disk space usage even without using monorepo
  • each example can be tested independently, no need to load all packages from root
  • it was more easy to update packages, it does not checks packages in all examples each time
    For this I think using pnpm is more adequate for thisl

But if there are strong reasons for not to use pnpm please tell me and I can prepare a version of the PR excluding then packages config changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants