feat: create job handle result after proposal active#825
feat: create job handle result after proposal active#825fibonacci998 wants to merge 1 commit intodevelopfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| if (startBlock >= endBlock) { | ||
| return; | ||
| } | ||
| const eventAttributes = await EventAttribute.query() |
There was a problem hiding this comment.
em tách cái đoạn này thành 1 hàm
getActiveProposals(fromBlock, toBlock): Proposal[]
trả thêm data của proposal, như vậy sẽ test đc hàm đó nhé
There was a problem hiding this comment.
em nghĩ không cần lắm ấy, vì cái proposal cũng không đủ thông tin của cái erc20 kia (thiếu mất address contract erc20), cái address này không có trong proposal, mà nó trong event của block luôn
https://aurascan.io/block/6904451
https://aurascan.io/votings/13
No description provided.