Skip to content

Conversation

Copy link

Copilot AI commented Nov 24, 2025

The documentation incorrectly listed "Expected" and "Conditionally Expected" as valid ADaM core values. Per ADaM IG 1.3 pg 14, ADaM only uses: Required, Conditionally Required, and Permissible.

Changes

  • README.Rmd/README.md: Updated core attribute description in ds_vars table to specify:
    • ADaM IG 1.3: "Required", "Conditionally Required", "Permissible"
    • SDTM: "Required", "Expected", "Permissible"
  • Building_Specification_Readers.Rmd: Added standard-specific core values

Scope

Validation logic in R/validators.R unchanged to avoid breaking existing metadata that may use the broader set of values.

Original prompt

This section details on the original issue you should resolve

<issue_title>Documentation: core in Readme</issue_title>
<issue_description>image

In ADaM IG, core can be Required, Conditionally required or Permissible (ADAM IG 1.3 pg 14)
image

SDTM IG 3.4 page 22
image

It is not clear what core values are allowed. Furthermore, in CDISC library, only Req, Cond Perm is used for ADaM and SDTM Req, Exp and Perm. Are these values also acceptable for Core?</issue_description>

<agent_instructions>I need to update the information in the Readme to be more aligned with ADaM IG screenshot provided in the issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update Readme to clarify core values Align core attribute documentation with ADaM IG 1.3 and SDTM standards Nov 24, 2025
Copilot AI requested a review from bms63 November 24, 2025 01:09
Copilot finished work on behalf of bms63 November 24, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants