Open
Conversation
ruben-iteng
requested changes
Jul 1, 2025
packages/sd-card-slots/README.md
Outdated
Contributor
There was a problem hiding this comment.
Is the readme empty on purpose?
Co-authored-by: RubenB-ITENG <94007802+ruben-iteng@users.noreply.github.com>
Co-authored-by: RubenB-ITENG <94007802+ruben-iteng@users.noreply.github.com>
Co-authored-by: RubenB-ITENG <94007802+ruben-iteng@users.noreply.github.com>
ruben-iteng
reviewed
Jul 4, 2025
| sdbus.DAT0 ~ package.DAT0D0 | ||
| sdbus.DAT1 ~ package.DAT1RSV | ||
| sdbus.DAT2 ~ package.DAT2RSV | ||
| sdbus.CD ~ package.CD |
Contributor
There was a problem hiding this comment.
Suggested change
| sdbus.CD ~ package.CD | |
| sdbus.CD ~ package.CD | |
| sdbus.VSS1 ~ package.GND |
I actually don't understand why sdbus has VSS1 and VSS2. This should probably be VSS + a separate Electrical for SHIELD (which is Called GND in this package).
ruben-iteng
requested changes
Jul 9, 2025
packages/sd-card-example/ato.yaml
Outdated
| default: | ||
| entry: main.ato:App | ||
| hide_designators: true | ||
| #package: |
Contributor
There was a problem hiding this comment.
Will the example be published ?
Comment on lines
+3
to
+7
| import Resistor | ||
| import Capacitor | ||
| import SPI | ||
| import ElectricLogic | ||
| import ElectricPower |
Comment on lines
+8
to
+12
| import Resistor | ||
| import Capacitor | ||
| import SPI | ||
| import ElectricLogic | ||
| import ElectricPower |
| @@ -0,0 +1,33 @@ | |||
| # SD and microSD Card Slots | |||
|
|
|||
Contributor
There was a problem hiding this comment.
maybe short description
Comment on lines
+107
to
+109
| perst_n = new ElectricLogic | ||
| clkreq_n = new ElectricLogic | ||
| refclk = new DifferentialPair |
Contributor
There was a problem hiding this comment.
might be nice to write full name for readability
packages/sd-card/main.ato
Outdated
| logic.command.line ~ pins.CMD | ||
| logic.chip_select.line ~ pins.CD_DAT3 | ||
|
|
||
| #trait has_single_electric_reference_shared |
Contributor
There was a problem hiding this comment.
delete or un-comment (or is it broken ?)
packages/sd-card/slot-driver.ato
Outdated
Comment on lines
4
to
9
| import SPI | ||
| import Electrical | ||
| import ElectricPower | ||
| import ElectricSignal | ||
| import ElectricLogic | ||
| import Resistor |
| pass | ||
|
|
||
|
|
||
| module SDSlotDriverSS from SDSlotDriver: |
| from "atopile/sd-card/mech.ato" import SDMechSlotInterfaceMicro, SDMechSlotInterfaceBig | ||
|
|
||
| module SDSlot: | ||
| #slot_pins = new SDSlotPins |
Contributor
There was a problem hiding this comment.
why is this commented out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.