Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Convert Directory and File classes to JavaScript #1226

Merged
merged 10 commits into from
Mar 6, 2018
Merged

Conversation

winstliu
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Converts the Directory and File-related classes to JavaScript. I plan on investigating switching tree-view over to @atom/watcher, which the JavaScript conversion will help with.

Alternate Designs

None.

Benefits

JavaScript!

Possible Drawbacks

Potential regressions. I'd like to think that spec coverage is pretty good for tree-view but I'll be using this branch for a while before merging to play it extra safe.

Applicable Issues

None.

@daviwil
Copy link
Contributor

daviwil commented Feb 23, 2018

I considered doing this too but I wondered if it'd totally break a bunch of pending PRs. Is there anything we absolutely want to merge before doing this?

@winstliu
Copy link
Contributor Author

@daviwil Thanks for bringing that up. I've identified the following PRs that also modify one of the files changed in this PR:
#1144
#1048
#955 (already conflicting)
#744 (already conflicting)
#658 (already conflicting)
#614 (already conflicting)
#469 (already conflicting)
#344 (already conflicting)

Therefore I believe the ones we should look at and potentially merge before this one are #1144 and #1048. It looks like @lee-dohm is already helping with #1048, which only leaves #1144.

@daviwil
Copy link
Contributor

daviwil commented Feb 28, 2018

Just merged #1144 and #1048! Proceed :)

@winstliu winstliu force-pushed the wl-directory-file-js branch from c874d9b to 089acd6 Compare February 28, 2018 23:36
@winstliu winstliu merged commit fff1679 into master Mar 6, 2018
@winstliu winstliu deleted the wl-directory-file-js branch March 6, 2018 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants