This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Convert Directory and File classes to JavaScript #1226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Converts the Directory and File-related classes to JavaScript. I plan on investigating switching tree-view over to
@atom/watcher
, which the JavaScript conversion will help with.Alternate Designs
None.
Benefits
JavaScript!
Possible Drawbacks
Potential regressions. I'd like to think that spec coverage is pretty good for tree-view but I'll be using this branch for a while before merging to play it extra safe.
Applicable Issues
None.