This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add getLongTitle #72
Open
Add getLongTitle #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
reviewed
Sep 29, 2016
| @@ -46,16 +47,70 @@ class ImageEditor | |||
| destroy: -> | |||
| @subscriptions.dispose() | |||
|
|
|||
| # Retrieves the filename of the open file. | |||
| # Essential: Retireves all {ImageEditor}s in the workspace. | |||
There was a problem hiding this comment.
Retireves should be Retrieves
Ben3eeE
force-pushed
the
getLongTitle
branch
from
2f58abf to
6902571
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates the behavior of
TextEditors when opening multiple images with the same filename in different folders by copying the relevant parts from theTextEditorclass.Having to copy functions from the
TextEditorclass to achieve basic functionality might be poor design. Same goes for the pending pane item functions. If someone has a better idea I can try to implement that.Should I add specs for this?
Before:
After: