Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Remove 'cmd-t' / 'ctrl-t' for 'toggle-file-finder' #106

Closed
wants to merge 1 commit into from

Conversation

mehcode
Copy link

@mehcode mehcode commented Jun 1, 2015

Replaces #92 and #78
See #92 (comment)


The ctrl- and cmd- keybindings are a precious resource. Having two for the same package is 🐼.

However I agree that we'd need to remove cmd-t / ctrl-t

  • We have ctrl-shift-p for the command panel
  • We could have ctrl-alt-p for a project switcher (the spec runner doesn't need a keyboard shortcut as the average user doesn't care)
  • It mimics sublime in a very obvious way

@lee-dohm
Copy link
Contributor

lee-dohm commented Jun 1, 2015

Before this is merged, we should probably scour the documentation to ensure that there are no references to Cmd/Ctrl+T.

@mnquintana
Copy link
Contributor

Also just a note for after this is merged: we should probably add a note in the release notes for the version of Atom that incorporates this change about how to re-add this keybinding for those who miss it (and you know there will be people who'll miss it)

@winstliu
Copy link
Contributor

winstliu commented Jun 1, 2015

Still 👎 on removing the -T keybinding for the reasons listed in #92. Ctrl+T is newtab in every major web browser, t is the fuzzy finder in Github...

@mehcode
Copy link
Author

mehcode commented Jun 2, 2015

The big reason that sways me in favor of cmd-p over cmd-t is that all the similar bindings you mention are new tab/document/file, find file. cmd-p is far more than just find file, it's not quite to sublime's level of "goto anything" but its close.


With that said, I really don't care. I just want to get rid of one of them. I don't mind updating the PRs if the decision is in the reverse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants