Merged
Conversation
Member
Amiditin
commented
Dec 5, 2025
- [Feature] Рефактор eslint конфига #525
There was a problem hiding this comment.
Pull request overview
This PR updates ESLint configuration rules and removes numerous eslint-disable comments throughout the codebase. The changes include:
- Disabling strict TypeScript rules (
no-non-null-assertion,explicit-module-boundary-types,explicit-function-return-type) - Enabling new rules like
no-unnecessary-conditionand updating Node.js-related rules - Updating ESLint and related plugin dependencies to newer versions
- Removing eslint-disable comments and adjusting code to comply with updated rules
Reviewed changes
Copilot reviewed 61 out of 63 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| config/eslint/src/rules/typescript.rules.ts | Disables strict TypeScript rules and adds no-unnecessary-condition rule |
| config/eslint/src/rules/react.rules.ts | Disables jsx-no-leaked-render rule and removes TODO comment |
| config/eslint/src/rules/node.rules.ts | Enables Node.js feature checks and adds node protocol preference rules |
| config/eslint/src/rules/base.rules.ts | Enables no-continue, no-param-reassign to off, adds new ES2022 rules |
| config/eslint/src/index.ts | Updates ecmaVersion to 2022 and React version detection |
| config/eslint/package.json | Updates ESLint plugin versions to latest |
| yarn/test-utils/src/package.utils.ts | Changes private fields from definite assignment to optional types |
| yarn/test-utils/src/test.env.ts | Removes eslint-disable comments for param-reassign |
| yarn/plugin-test/sources/abstract-test.command.tsx | Removes optional chaining on NODE_OPTIONS (potential bug) |
| yarn/plugin-checks/sources/*.ts | Removes optional chaining on NODE_OPTIONS in multiple files (potential bugs) |
| code/code-schematics/src/helpers/run-schematics.helper.ts | Changes conditional logic for dry-run and debug messages (behavioral change) |
| code/code-pack/src/pack.utils.ts | Declares boolean variable without initialization (potential bug) |
| yarn/plugin-release/sources/release-create.command.ts | Declares string variables without initialization |
| code/code-icons/src/icons.ts | Removes fallback empty object for replaceAttrValues |
| cli/cli-ui-stack-trace/src/stack-trace.component.tsx | Removes unnecessary null check |
| prettier/plugin/src/*.ts | Removes eslint-disable comments |
| yarn.lock & .pnp.cjs | Updates dependency versions and lockfile |
Files not reviewed (1)
- .pnp.cjs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TorinAsakura
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.