Skip to content

feat(config): eslint rules#526

Merged
TorinAsakura merged 6 commits intomasterfrom
feat/eslint-config
Dec 7, 2025
Merged

feat(config): eslint rules#526
TorinAsakura merged 6 commits intomasterfrom
feat/eslint-config

Conversation

@Amiditin
Copy link
Member

@Amiditin Amiditin commented Dec 5, 2025

@Amiditin Amiditin requested a review from TorinAsakura December 5, 2025 04:16
@Amiditin Amiditin self-assigned this Dec 5, 2025
@Amiditin Amiditin removed the request for review from TorinAsakura December 5, 2025 04:22
@Amiditin Amiditin marked this pull request as draft December 5, 2025 04:22
@Amiditin Amiditin marked this pull request as ready for review December 6, 2025 04:26
@Amiditin Amiditin requested a review from Copilot December 6, 2025 04:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ESLint configuration rules and removes numerous eslint-disable comments throughout the codebase. The changes include:

  • Disabling strict TypeScript rules (no-non-null-assertion, explicit-module-boundary-types, explicit-function-return-type)
  • Enabling new rules like no-unnecessary-condition and updating Node.js-related rules
  • Updating ESLint and related plugin dependencies to newer versions
  • Removing eslint-disable comments and adjusting code to comply with updated rules

Reviewed changes

Copilot reviewed 61 out of 63 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
config/eslint/src/rules/typescript.rules.ts Disables strict TypeScript rules and adds no-unnecessary-condition rule
config/eslint/src/rules/react.rules.ts Disables jsx-no-leaked-render rule and removes TODO comment
config/eslint/src/rules/node.rules.ts Enables Node.js feature checks and adds node protocol preference rules
config/eslint/src/rules/base.rules.ts Enables no-continue, no-param-reassign to off, adds new ES2022 rules
config/eslint/src/index.ts Updates ecmaVersion to 2022 and React version detection
config/eslint/package.json Updates ESLint plugin versions to latest
yarn/test-utils/src/package.utils.ts Changes private fields from definite assignment to optional types
yarn/test-utils/src/test.env.ts Removes eslint-disable comments for param-reassign
yarn/plugin-test/sources/abstract-test.command.tsx Removes optional chaining on NODE_OPTIONS (potential bug)
yarn/plugin-checks/sources/*.ts Removes optional chaining on NODE_OPTIONS in multiple files (potential bugs)
code/code-schematics/src/helpers/run-schematics.helper.ts Changes conditional logic for dry-run and debug messages (behavioral change)
code/code-pack/src/pack.utils.ts Declares boolean variable without initialization (potential bug)
yarn/plugin-release/sources/release-create.command.ts Declares string variables without initialization
code/code-icons/src/icons.ts Removes fallback empty object for replaceAttrValues
cli/cli-ui-stack-trace/src/stack-trace.component.tsx Removes unnecessary null check
prettier/plugin/src/*.ts Removes eslint-disable comments
yarn.lock & .pnp.cjs Updates dependency versions and lockfile
Files not reviewed (1)
  • .pnp.cjs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Amiditin Amiditin requested a review from TorinAsakura December 6, 2025 04:42
@TorinAsakura TorinAsakura merged commit 797c4ee into master Dec 7, 2025
6 checks passed
@TorinAsakura TorinAsakura deleted the feat/eslint-config branch December 7, 2025 01:45
@Amiditin Amiditin linked an issue Dec 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Рефактор eslint конфига

3 participants