Feat: user login with email and password PR #62
Closed
+906
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10624400 | Triggered | Generic Password | 21fd82e | src/test/signin.test.ts | View secret |
| 10624401 | Triggered | Generic Password | 21fd82e | src/test/signin.test.ts | View secret |
| 10624402 | Triggered | Generic Password | 21fd82e | src/test/signin.test.ts | View secret |
| 10802115 | Triggered | Generic Password | 21fd82e | src/test/signin.test.ts | View secret |
| 10811125 | Triggered | Generic Password | 21fd82e | src/test/signin.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Ndevu12
changed the title
This is a combination of 2 commits. This is a combination of 3 commits. Implemented user registration feature with input validation, password hashing, and database integration user login feature Implemented user registration feature with input validation, password hashing, and database integration fix(user registration): resolve registration bug - ensure that a user provide neccessary inputs - restructure user entity - refactor other codes depending on user registration logic [Fixes #39] rebasing from develop , adding verifie route and service and send email to the user rebasing from develop , adding verifie route and service and send email to the user fix(user registration): resolve registration bug - ensure that a user provide neccessary inputs - restructure user entity - refactor other codes depending on user registration logic [Fixes #39] Update README.md user login feature
Ndevu12
added
In Progress
aimedivin
requested changes
May 6, 2024
| res.status(401).json({ Message: 'Sorry, Something went wrong' }); | ||
| return; | ||
| } | ||
| }; |
There was a problem hiding this comment.
@Ndevu12 , in this file, focus on validating the token, fetching user data, and attach it to the request object. no need to verify the user type, it is already handled in the RBAC Issue.
Ndevu12
added
backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new feature that allows users to log in using their email and password.
Task completed
Task involved:
How should this be manually tested?