Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user registration): resolve registration bug #57

Merged
merged 1 commit into from
May 3, 2024

Conversation

aimedivin
Copy link
Member

What does this PR do?

This PR aims to fix a bug identified in the user registration process.

Description of Task to be completed?

Task involved:

  • Ensure that necessary data(fields) are extracted from the request body.
  • Restructure user entity.
  • Check that related code modules dependent on user registration functionality behave as expected.
  • fix issues in the response file.
  • Update test for register route.

How should this be manually tested?

git clone https://github.com/atlp-rwanda/knights-ecomm-be.git
cd knights-ecomm-be
git checkout hotfix-user-registration-bug
npm install
npm run dev

What are the relevant pivotal tracker/Trello stories?

#39

@aimedivin aimedivin force-pushed the hotfix-user-registration-bug branch 2 times, most recently from 044d167 to 681cddb Compare May 3, 2024 12:51
@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8942762992

Details

  • 45 of 51 (88.24%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.0%) to 71.098%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/response.utils.ts 1 2 50.0%
src/controllers/authController.ts 23 28 82.14%
Totals Coverage Status
Change from base Build 8919969005: -2.0%
Covered Lines: 110
Relevant Lines: 140

💛 - Coveralls

@aimedivin aimedivin force-pushed the hotfix-user-registration-bug branch from 681cddb to d9dbd1b Compare May 3, 2024 14:48
- ensure that a user provide neccessary inputs
- restructure user entity
- refactor other codes depending on user registration logic

[Fixes #39]
@aimedivin aimedivin force-pushed the hotfix-user-registration-bug branch from d9dbd1b to c7b1dc4 Compare May 3, 2024 17:37
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved !

@faid-terence faid-terence merged commit c265908 into develop May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants