Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to select which files to export. #307

Merged

Conversation

DanteNiewenhuis
Copy link
Contributor

Summary

Added the option to select which files to export.
The user can provide a list of files to export to the experiment json file which specifies which files to export.
If not specified, all files are exported.

Example Json files:

{
    "name": "surfsara_day",
    "topologies": [
        {
            "pathToFile": "topologies/batteries/surfsara_1000_10000_160.json"
        }
    ],
    "workloads": [
        {
            "pathToFile": "workload_traces/surfsara/2022-10-01_2022-10-02",
            "type": "ComputeWorkload"
        }
    ],
    "allocationPolicies": [{
        "policyType": "Mem"
    }],
    "exportModels": [
        {
            "exportInterval": 3600,
            "filesToExport": ["battery"],
        }
    ]
}

This experiment will only export the battery file.
Using this can significantly reduce the size of the output files.

Next to adding this option, "computeExportConfig" has been moved to the exportModel input.

Implementation Notes ⚒️

N / A

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

"computeExportConfig" is moved from the "experiment", to the "exportModel"

Simply specify none (N/A) if not applicable.

@vlogic
Copy link
Member

vlogic commented Feb 18, 2025

@DanteNiewenhuis maybe add this to the documentation.

@DanteNiewenhuis
Copy link
Contributor Author

DanteNiewenhuis commented Feb 18, 2025

@vlogic, have updated the documentation to reflect the changes

Copy link
Member

@vlogic vlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement.

@DanteNiewenhuis DanteNiewenhuis merged commit ee770ff into atlarge-research:master Feb 18, 2025
4 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the output-update branch February 18, 2025 10:58
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e9080b6) to head (8345c6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #307   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants