Fixed two bugs that could cause infinite loops #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two bugs that could create infinite loops:
In SimTraceWorkload, it could be the case that the the remaining work for a trace is so small, that it would make the remaining duration also 0. In that case, it would look forever. I have added an extra check that solves this problem.
In SimDistributor I was changing element of a Hashset while looping over the Hashset. This crashes java.
I solved this by creating a new Hashset.
Implementation Notes ⚒️
N / A
External Dependencies 🍀
N / A
Breaking API Changes⚠️
N / A
Simply specify none (N/A) if not applicable.