Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two bugs that could cause infinite loops #304

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

DanteNiewenhuis
Copy link
Contributor

Summary

Fixed two bugs that could create infinite loops:

In SimTraceWorkload, it could be the case that the the remaining work for a trace is so small, that it would make the remaining duration also 0. In that case, it would look forever. I have added an extra check that solves this problem.

In SimDistributor I was changing element of a Hashset while looping over the Hashset. This crashes java.
I solved this by creating a new Hashset.

Implementation Notes ⚒️

N / A

External Dependencies 🍀

N / A

Breaking API Changes ⚠️

N / A

Simply specify none (N/A) if not applicable.

Copy link
Member

@vlogic vlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested it locally the example trace with the example experiment is now working again.

@DanteNiewenhuis DanteNiewenhuis merged commit e9080b6 into atlarge-research:master Feb 17, 2025
4 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the bug-fix branch February 17, 2025 11:59
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (20d8587) to head (7923b1f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #304   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vlogic pushed a commit to vlogic/opendc that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants