Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metrics and parquet output #195

Merged

Conversation

DanteNiewenhuis
Copy link
Contributor

Summary

Added power_draw to the output metrics. Renamed power_total to energy_usage

Implementation Notes ⚒️

The metric power_total is renamed to energy_usage to better explain what it does.
power_draw is added as an additional metric.

power_draw states the power drawn by the component when monitored in Watt.
energy_usage takes the sample rate into account, en states the energy used since the previous sample in Joule.

The folder structure of the parquet files is changed. All three parquet files are now put in the same folder, with a different name.

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

  1. power_total is renamed to energy_usage
  2. The folder structure of the parquet files is changed.

Simply specify none (N/A) if not applicable.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (616017b) 0.00% compared to head (0465e2d) 70.84%.

Files Patch % Lines
.../telemetry/export/parquet/ParquetHostDataWriter.kt 0.00% 15 Missing ⚠️
.../telemetry/export/parquet/ParquetComputeMonitor.kt 0.00% 3 Missing ⚠️
...rg/opendc/web/runner/internal/WebComputeMonitor.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #195       +/-   ##
=============================================
+ Coverage          0   70.84%   +70.84%     
- Complexity        0     2180     +2180     
=============================================
  Files             0      354      +354     
  Lines             0     9808     +9808     
  Branches          0     1036     +1036     
=============================================
+ Hits              0     6948     +6948     
- Misses            0     2537     +2537     
- Partials          0      323      +323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanteNiewenhuis DanteNiewenhuis merged commit 10c4710 into atlarge-research:master Feb 14, 2024
7 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the output-update branch February 14, 2024 10:52
DanteNiewenhuis added a commit to DanteNiewenhuis/opendc that referenced this pull request Feb 18, 2024
* Updated metrics and parquet output

* fixed typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants