Skip to content

Fix typehint on enums to reflect that AWS might add new values #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typehint on enums to reflect that AWS might add new values #1923

wants to merge 1 commit into from

Conversation

jderusse
Copy link
Member

No description provided.

@jderusse jderusse force-pushed the psalm-fix branch 2 times, most recently from c7a50a7 to 6cb7dfa Compare July 24, 2025 08:21
@jderusse jderusse mentioned this pull request Jul 24, 2025
Draft
@jderusse jderusse changed the title Help psalm to detect enum variables and avoid the More/LessSpecificReturn exceptions Fix typehint on enums to reflect that AWS might add new values Jul 24, 2025
@GrahamCampbell
Copy link
Contributor

Hmmm, but the type RuntimeName::*|string is identical to string, so we lose the value of having the specific string values.

@jderusse jderusse mentioned this pull request Jul 24, 2025
Open
@jderusse
Copy link
Member Author

Hmmm, but the type RuntimeName::*|string is identical to string, so we lose the value of having the specific string values.

Yeah, that's true. See the reasoning here #1921 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @GrahamCampbell