Skip to content

Conversation

@J007X
Copy link
Collaborator

@J007X J007X commented Mar 22, 2023

This PR fixes #924.

Description of changes

Implemented changes as designed/discussed in #924.

Possible influences of this PR.

Provide a Data Pack level attribute interface, based on lower level interface implemented in #921

Test Conducted

Unit tests, and profiling test for typical scenario.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #926 (3fe14a9) into master (6e2d6ea) will increase coverage by 0.01%.
The diff coverage is 83.80%.

❗ Current head 3fe14a9 differs from pull request most recent head 07109cc. Consider uploading reports for the commit 07109cc to get more accurate results

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.01%     
==========================================
  Files         256      256              
  Lines       19851    19954     +103     
==========================================
+ Hits        16091    16178      +87     
- Misses       3760     3776      +16     
Impacted Files Coverage Δ
forte/data/data_store.py 91.59% <75.36%> (-1.72%) ⬇️
forte/data/ontology/ontology_code_generator.py 89.75% <100.00%> (ø)
tests/forte/data/data_store_test.py 95.96% <100.00%> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data_Pack level attribute(/"primitive-like") direct access interface (for user) design/requirements/considerations

1 participant