Prevent Guides View From Fetching Upon Appearance #499
+36
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time GuidesView appears, it fetches from Firebase every time. We don't want to do that due to performance reasons.
Instead, we should fetch it once and keep it in memory during the lifetime of the application.
The reason why this is happening is that in homeDrawerContentView, we are creating a new instance of GuidesView in the switch statement where GuidesViewModel is being initialized each time.
Instead, we should move the initialization of GuidesViewModel outside of GuidesView into HomeView and pass it into GuidesView like what we are doing for DiningHallsViewModel?