Added feedback button to search bar #477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwongeecs
requested changes
Nov 25, 2025
Collaborator
justinwongeecs
left a comment
justinwongeecs
left a comment
There was a problem hiding this comment.
nice work! just a couple small things
Comment on lines
+31
to
+39
| Button(action: { | ||
| isPresentingFeedbackForm = true | ||
| }) { | ||
| Image(systemName: "bubble.left.and.bubble.right") | ||
| .foregroundStyle(Color(BMColor.searchBarIconColor)) | ||
| .fontWeight(.semibold) | ||
| .frame(width: 30, alignment: .center) | ||
| } | ||
| .accessibilityLabel("Send Feedback") |
Collaborator
There was a problem hiding this comment.
refactor into its own private var
Comment on lines
+41
to
+49
| Button(action: { | ||
| viewModel.clearSearchText() | ||
| }) { | ||
| Image(systemName: "xmark") | ||
| .foregroundStyle(Color(BMColor.searchBarIconColor)) | ||
| .fontWeight(.semibold) | ||
| .frame(width: 30, alignment: .center) | ||
| } | ||
| .accessibilityLabel("Clear search text") |
Collaborator
There was a problem hiding this comment.
keep the private var clearTextIcon like before and use it here. Maybe rename it to something like clearTextButton.
| SearchResultsView() | ||
| .environmentObject(SearchViewModel(chooseMapMarker: { _ in }) { _ in }) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Remove unnecessary newline here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.