Skip to content

smoothing functions do not use **kwargs for the astropy smoothing work #1147

Open

Description

@teuben

I'd like to use specutils.manipulation.gaussian_smooth, which calls astropy's smoothing functions, but specutils has a fixed API, does not pass on any possible **kwargs. Is this by design?

My reason is I'd like to get the boundary='expand' behavior on the edge, instead of the default boundary='fill'.

This particular case I was able to hack myself, but perhaps there are unintended consequences by opening this API up.

I can otherwise submit a PR.

Activity

  1. teuben commented on Jun 25, 2024

    @teuben
    ContributorAuthor

    In the upstream code (dysh) where we encountered this problem, we have switched to calls astropy's functions with boundary='expand' and so this issue has gone away for us. Yet, one could argue this is a problem here, unless there was a (design) reason not to pass anything ikn **kwargs.

  2. reopened this on Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions