Add tests for IO Error retries #13627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
added
internal
konstin
force-pushed
the
konsti/basic-retry-tests
branch
from
93bbfd1 to
0309430
Compare
konstin
force-pushed
the
konsti/advanced-retry-tests
branch
from
ce49c26 to
4802438
Compare
konstin
commented
Jun 6, 2025
konstin
force-pushed
the
konsti/basic-retry-tests
branch
from
0309430 to
ca60ba7
Compare
konstin
force-pushed
the
konsti/advanced-retry-tests
branch
from
fad5a74 to
3f42b70
Compare
Contributor
|
|
jtfmumm
reviewed
Jun 9, 2025
Cargo.toml
Outdated
| windows-result = { version = "0.3.0" } | ||
| windows-sys = { version = "0.59.0", features = ["Win32_Foundation", "Win32_Security", "Win32_Storage_FileSystem", "Win32_System_Ioctl", "Win32_System_IO", "Win32_System_Registry"] } | ||
| wiremock = { version = "0.6.2" } | ||
| wiremock = { git = "https://github.com/konstin/wiremock-rs", rev = "131ad0a3e7a247c867fc290319047fc086995271" } |
Contributor
There was a problem hiding this comment.
Are you waiting to merge until this is accepted upstream?
Contributor
There was a problem hiding this comment.
If not, can you add a comment explaining the respond_with_err change we're using?
Member
Author
There was a problem hiding this comment.
Since upstream is not responding, I'll fork into the astral org and tag the commit instead.
jtfmumm
approved these changes
Jun 9, 2025
Often, HTTP requests don't fail due to server errors, but from spurious network errors such as connection resets. reqwest surfaces these as `io::Error`, and we have to handle their retrying separately.
konstin
force-pushed
the
konsti/advanced-retry-tests
branch
from
3f42b70 to
61c7815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, HTTP requests don't fail due to server errors, but from spurious network errors such as connection resets. reqwest surfaces these as
io::Error, and we have to handle their retrying separately.Companion PR: LukeMathWalker/wiremock-rs#159