[ruff] Lint for implicit concatenation of t-strings and f-strings
#18396
Conversation
dylwil3
added
rule
|
I think we should wait with adding this rule until it's clear that it isn't a syntax error. We otherwise risk having a deprecated rule even before 3.14 is released |
That's fine with me! Just thought I'd knock it out before I forgot - happy to close/turn this to draft until then. |
|
|
I love the rule itself. Thanks for implementing it so quickly |
| checker: &Checker, | ||
| string_like: StringLike, | ||
| ) { | ||
| if !checker.target_version().supports_t_strings() { |
There was a problem hiding this comment.
I don't see much harm to run the rule even if the target version doesn't support t strings
There was a problem hiding this comment.
I guess the issue is that the user would also see a version specific syntax error. But that's fine I guess?
|
I think the mkdocs test fails because it's testing the syntax of the docs using Python 3.13 |
As advertised!
Feel free to push back about the name, the decision to put this in the AST checker instead of working harder and putting it in the tokens checker, and anything else 😄