Fix Bug and add Feature to Group also for footprint #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Group componets for footprint size
Carmine12328
changed the title
asterix24
reviewed
Jun 12, 2019
lib/cfg.py
Outdated
|
|
||
| if not csv_file: | ||
| merge_file_item = os.path.join(path_file, bom_name) +'.xlsx' | ||
| if not csv_file: |
There was a problem hiding this comment.
Non si poteva usare lo stesso if? c'è differenza a fare lo stesso controllo?
asterix24
reviewed
Jun 12, 2019
mergebom_class.py
Outdated
| self.group() | ||
| self.count() | ||
| d = {} | ||
| listApp = [] |
There was a problem hiding this comment.
Queste variabili vendono utilizzate fuori dal for? se no, perchè le dichiari qui e poi le usi solo all'interno dei cicli?
asterix24
reviewed
Jun 12, 2019
mergebom_class.py
Outdated
|
|
||
| d = {} | ||
| i = 0 | ||
| e = 0 |
There was a problem hiding this comment.
cosa sono i e? volevi fare l'elenco delle vocali? e poi dove vendono usate?
asterix24
reviewed
Jun 12, 2019
mergebom_class.py
Outdated
| d[item[self.TABLE_FOOTPRINT]] = [item] | ||
|
|
||
| listApp.append(d.values()) | ||
| for x in listApp[0]: |
There was a problem hiding this comment.
Queste due righe ce senso hanno? hai una lista di liste, o semplicemente una lista? non ha molto senso fare una lista di liste per un elemento solo e poi ciclare sul primo elemento della lista..
asterix24
reviewed
Jun 12, 2019
mergebom_class.py
Outdated
| self.table[category], key=lambda x: x[ | ||
| self.TABLE_COMMENT]) | ||
| # Convert all ORDERED designator in a numeric format | ||
| if category in ["R", "C", "L", "Y"]: |
There was a problem hiding this comment.
Questo penso che non ne hai bisogno, perchè stai già ciclando sulle categorie..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Bug of Parameters Controls in cfg_altiumWorkspace and add Feature Group componets for footprint size(with test)