Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return resp.content instead of json when response_class is binary #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duczen
Copy link

@duczen duczen commented Jun 19, 2018

When trying to get a stored recording with client.recordings.getStoredFile an exception is thrown, ValueError: No JSON object could be decoded as the content is not json. When the response_class is binary this returns the content directly without trying to parse it as json.

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant