-
Notifications
You must be signed in to change notification settings - Fork 13
fix: Decouple arch-specific constants from PagingConstsTrait trait definitions, fix specifications, and prove axioms.
#532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rikosellic
wants to merge
32
commits into
asterinas:main
Choose a base branch
from
rikosellic:paging-const
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3574feb
fix unverified code
hiroki-chen a82a3d1
prove: 7 page table config axioms and rename to `lemma_`
Marsman1996 f259d2b
prove: 5 freshness axioms via pigeonhole over finite Set<int>
Marsman1996 90b76d6
prove: axiom_leading_bits_bounded via trait method
Marsman1996 e4dee5c
Merge remote-tracking branch 'origin/main' into fix-axiom
Marsman1996 aad431b
Merge branch 'pr-530' into paging-const
rikosellic e6c4294
Move `lemma_nr_subpage_per_huge_eq_nr_entries` into `specs/arch``
rikosellic c28b7fd
Move `lemma_finite_int_set_has` into `vstd_extra`
rikosellic 221d28d
decouple hard-coded constants in `PagingConstsTrait`, but add admits
rikosellic e6b6665
Move `lemma_nr_subpage_per_huge_bounded` into `specs``
rikosellic a452e96
fix admit in `pte_index_bit_offset`
rikosellic f53a590
Simplify
rikosellic 17e7085
Minor
rikosellic 824cd5d
Fix hardcoded `CursorOwner` invariants
rikosellic ecb50ba
more corrections
rikosellic de67cb3
Minor
rikosellic 56c0b0f
minor
rikosellic 26e1ec9
Merge remote-tracking branch 'upstream/main' into paging-const
rikosellic f51832b
Make `AbstractVaddr` `PagingConst` generic
rikosellic a357fda
fix two wrong usage
rikosellic c90b4a6
another fix
rikosellic 4130e2d
fix: syntax error
Marsman1996 1468fdf
prove: by adding assumes for NR_LEVELS/NR_ENTRIES
bd8e7f8
spec: genericized from NR_ENTRIES/INC_LEVELS to nr_subpage_per_huge::…
Marsman1996 21f3411
Merge remote-tracking branch 'origin/main' into paging-const
Marsman1996 3d1adde
prove: remove more assume
Marsman1996 17fd6bc
prove: bridging assume
Marsman1996 da719f3
prove: arch-specific assume in owners
Marsman1996 5dbd64d
prove: PAGE_SIZE related assumes
Marsman1996 f51364a
prove: inv assume
Marsman1996 9043c13
prove: more assume and admit
Marsman1996 9200dd2
prove: 10 `admit()`
Marsman1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks suspicious. I do not think this assumption holds for all trait implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think LLM is misguided by the requirements in
PagingConstsTrait.