fix: Decouple arch-specific constants from PagingConstsTrait trait definitions, fix specifications, and prove axioms.#532
Draft
rikosellic wants to merge 32 commits into
Draft
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Closed
This comment was marked as resolved.
This comment was marked as resolved.
rikosellic
changed the title
PagingConsts axiomsPagingConstsTrait trait definitions, fix specifications, and prove axioms.
Collaborator
Author
|
And it turns out to be a big change, because This is wrong because there are 3-level page tables in other architectures. |
rikosellic
added
the
verification bug
Collaborator
Author
|
This PR is currently suspended. |
This comment was marked as resolved.
This comment was marked as resolved.
…<C>()/C::NR_LEVELS()
Marsman1996
force-pushed
the
paging-const
branch
from
07185cd to
fc13f8b
Compare
Resolved conflicts between paging-const genericization and upstream changes (PRs asterinas#531, asterinas#534, asterinas#537). Adapted upstream's new proven proofs to use generic C::NR_LEVELS()/nr_subpage_per_huge::<C>() forms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Marsman1996
force-pushed
the
paging-const
branch
from
fc13f8b to
21f3411
Compare
Collaborator
|
Reduce from 215 newly added |
rikosellic
commented
Jun 22, 2026
| /// Proves the concrete values of `vaddr_make` for the x86_64 paging configuration. | ||
| /// | ||
| /// For any `C: PagingConstsTrait`, since all configs share | ||
| /// `BASE_PAGE_SIZE == 4096`, `nr_subpage_per_huge == 512`, and `NR_LEVELS == 4`: |
Collaborator
Author
There was a problem hiding this comment.
This looks suspicious. I do not think this assumption holds for all trait implementations.
Collaborator
Author
There was a problem hiding this comment.
I think LLM is misguided by the requirements in PagingConstsTrait.
rikosellic
commented
Jun 22, 2026
| // FIXME: remove this once we have a more general | ||
| Self::BASE_PAGE_SIZE() == PAGE_SIZE, | ||
| Self::NR_LEVELS() == NR_LEVELS, | ||
| Self::BASE_PAGE_SIZE() / Self::PTE_SIZE() == NR_ENTRIES, |
Collaborator
Author
There was a problem hiding this comment.
We should remove these hard-coded constant requirements here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current verification design maps hard-coded x86-specific constants to the
PagingConstsTraitabstraction, which is incorrect because we can never extend the proof to other architectures. The new design is to prove the properties of abstractions (e.g.,CursorOwnerbased onPageTableConfig) purely with the const declarations inPagingConstTrait. And only use the arch-specific constants (controlled by attributes) when proving definitions instantiated withPagingConsts.