chore: run type tests in CI #110
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ah yes I completely forgot about it, thanks for that! and many thanks for TSTyche it's really awesome 🙏 |
commit: |
| "checkSuppressedErrors": true, | ||
| "checkSourceFiles": true, | ||
| "tsconfig": "./tsconfig.ci.json", | ||
| "checkSourceFiles": false, |
There was a problem hiding this comment.
The checkSourceFiles option is removed in the next major. It does way too much.
tsconfig.ci.json is not picked, because it does not include the test file. TSTyche default are used instead a they are rather strict.
Without tsconfig option set, packages/typed-openapi/tsconfig.json is loaded. I think that is right, or? Look for 'uses' line to see which TSConfig is loaded (documentation):
There was a problem hiding this comment.
yes it should be fine!
btw how did you find out that I started using TSTyche?
There was a problem hiding this comment.
btw how did you find out that I started using TSTyche?
GitHub told me: https://github.com/tstyche/tstyche/network/dependents
(;
| run: pnpm test | ||
|
|
||
| - name: Test types | ||
| run: pnpm --filter typed-openapi test:types |
There was a problem hiding this comment.
You can also test agains range of TypeScript versions. To be sure older version work as expected (if that is important). For example:
| run: pnpm --filter typed-openapi test:types | |
| run: pnpm --filter typed-openapi test:types --target '>=5.2' |
2 participants
This adds type tests to CI runs. Seems like they are not included currently. Was this simply overlooked in #108, or I misunderstood something?
Glad to see you found TSTyche useful. Please, always ping me if you have any questions.