Skip to content

ci: add informational lint checks - #70

Merged
pinkstrings merged 1 commit into
mainfrom
codex/lint-ci
Oct 9, 2026
Merged

pinkstrings merged 1 commit into
mainfrom
codex/lint-ci

Conversation

@pinkstrings

@pinkstrings pinkstrings commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Run the existing npm run lint command on pull requests targeting main and pushes to main, so lint findings are visible without adding a build or browser test suite.

Use Node from .nvmrc, cache npm downloads, cancel superseded runs, and cap each job at five minutes. Lint failures are informational during the initial rollout: they produce a warning and job summary while the check stays successful. Dependency installation failures still fail the job.

The current repository baseline has 24 lint errors and 18 warnings. Keeping lint informational avoids making existing debt a blocker for every change. Once the baseline is clean, remove continue-on-error to enforce lint. This PR changes only the workflow and does not change branch protection.

Testing

  • npm ci --no-audit --no-fund: succeeded using the repository's Node 20.13.1 (npm emitted existing dependency engine warnings).
  • npm run lint: ran twice; both runs reported 24 existing errors and 18 warnings. The timed run took 5.95 seconds locally; this excludes installation and runner setup.
  • actionlint 1.7.12: passed for .github/workflows/lint.yml.
  • Staged diff whitespace check passed; focused workflow review found no actionable issues.

The first GitHub Actions lint job completed successfully in 42 seconds, including setup, dependency installation, lint, and cleanup. The lint command reported the existing errors; the warning and job summary were emitted as intended. No website behavior changes, so no screenshot is needed.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
assembly-studio-website Ready Ready Preview Oct 9, 2026 3:45pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge and matches the intended informational rollout.

Summary

Adds informational lint checks for PRs targeting main and pushes to main.

  • A lint workflow checks changes to main and reports findings without blocking the check.

No actionable issues found. pinkstrings explicitly acknowledges existing lint debt and dependency engine warnings; lint enforcement is deferred until the baseline is clean.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[PR or push to main] --> B[Set up Node and npm cache]
  B --> C[Install dependencies]
  C -->|Failure| D[Fail job]
  C -->|Success| E[Run lint]
  E -->|Failure| F[Write warning and summary]
  E -->|Success| G[Successful check]
  F --> G
Loading

Reviews (1) · Last reviewed commit: "ci: add informational lint checks" · Reviewed by Greptile

@pinkstrings
pinkstrings merged commit b20ec49 into main Oct 9, 2026
4 checks passed
@pinkstrings
pinkstrings deleted the codex/lint-ci branch October 9, 2026 16:50

This branch was successfully deployed

1 active deployment
Preview — 83347a42 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants