Repository navigation
ci: add informational lint checks - #70
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
nastyaeremina
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing
npm run lintcommand on pull requests targetingmainand pushes tomain, so lint findings are visible without adding a build or browser test suite.Use Node from
.nvmrc, cache npm downloads, cancel superseded runs, and cap each job at five minutes. Lint failures are informational during the initial rollout: they produce a warning and job summary while the check stays successful. Dependency installation failures still fail the job.The current repository baseline has 24 lint errors and 18 warnings. Keeping lint informational avoids making existing debt a blocker for every change. Once the baseline is clean, remove
continue-on-errorto enforce lint. This PR changes only the workflow and does not change branch protection.Testing
npm ci --no-audit --no-fund: succeeded using the repository's Node 20.13.1 (npm emitted existing dependency engine warnings).npm run lint: ran twice; both runs reported 24 existing errors and 18 warnings. The timed run took 5.95 seconds locally; this excludes installation and runner setup.actionlint1.7.12: passed for.github/workflows/lint.yml.The first GitHub Actions lint job completed successfully in 42 seconds, including setup, dependency installation, lint, and cleanup. The lint command reported the existing errors; the warning and job summary were emitted as intended. No website behavior changes, so no screenshot is needed.