OUT-2790: implement soft delete for sync failed records caused by refresh token expiry#168
Merged
SandipBajracharya merged 2 commits intomasterfrom Dec 15, 2025
Merged
OUT-2790: implement soft delete for sync failed records caused by refresh token expiry#168SandipBajracharya merged 2 commits intomasterfrom
SandipBajracharya merged 2 commits intomasterfrom
Conversation
…by refresh token expiry
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rrojan
approved these changes
Dec 15, 2025
| } | ||
|
|
||
| async syncFailedRecords() { | ||
| async syncFailedRecords(includeDeleted = false) { |
Contributor
There was a problem hiding this comment.
It would be better to make this an opts object since calling the function as syncFailedRecords(true) might be vague. It's okay for now but can be changed
| accessToken: string | ||
| } | ||
|
|
||
| export const refreshTokenExpireMessage = 'Refresh token is expired' |
Contributor
There was a problem hiding this comment.
It would be best to put this in a constants file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.