Repository navigation
fix(editor): insert dynamic fields into the last focused editor - #241
Merged
Merged
Conversation
Sidebar dynamic fields always targeted the body editor, so with the cursor in the heading/subheading the field landed at the body's stale selection. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
arpandhakal
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Clicking a dynamic field in the sidebar always inserted into the body editor. With the cursor in the header heading/subheading (separate
MinimalEditorinstances), the field landed at the body editor's last selection instead of at the cursor. Editors now record themselves asfocusedEditoron focus, and the sidebar inserts there. Reported in https://share.zight.com/01a0f9d8-7489-76f0-9a66-565710bac9bbTesting Criteria
Impact & Surface Area of Change
Look at
DynamicFieldItem.tsx: falls back to the body editor if the focused editor was destroyed (e.g. segment switch remounting the header).2026-10-07.10-50-16.mov
🤖 Generated with Claude Code