Skip to content

fix(OUT-4242): render table text white on dark backgrounds - #240

Merged
priosshrsth merged 1 commit into
mainfrom
anit/out-4242-home-app-dark-text-in-tables-with-dark-background
Oct 7, 2026
Merged

priosshrsth merged 1 commit into
mainfrom
anit/out-4242-home-app-dark-text-in-tables-with-dark-background

Conversation

@priosshrsth

@priosshrsth priosshrsth commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

Table cells in the Home editor stayed dark grey when the background colour was dark, because the base .tiptap table td/th rule sets the colour directly on the cells and the .dark override only changed borders and backgrounds. Added text-white to td, th in the .dark .tiptap table block. OUT-4242

Testing Criteria

  • Dark background template with a table: header and body cells were rgb(33,43,54) before, rgb(255,255,255) after, matching the rest of the editor text.
  • Light backgrounds untouched (rule is scoped under .dark).
  • Not verified: client-facing Preview view.

Impact & Surface Area of Change

src/app/globals.css only — table cell text colour on dark backgrounds.
Screenshot 2026-10-07 at 09 51 33

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@linear-code

linear-code Bot commented Oct 7, 2026

Copy link
Copy Markdown

OUT-4242

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
client-home-v3 Ready Ready Preview Oct 7, 2026 4:07am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adjusts table text color in dark mode styling.

The change appears safe to merge and fixes table text on dark backgrounds.

What we checked:

  • Preview misses the fix: Both pages wrap ReadonlyEditor in .dark when the background is dark. They share the table styles changed here.

Summary

Adds white text to table body and header cells on dark backgrounds in src/app/globals.css.

  • Dark editor tables show white text in every cell.

Reviews (1) · Last reviewed commit: "fix(OUT-4242): render table text white o..." · Reviewed by Greptile

@SandipBajracharya SandipBajracharya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@priosshrsth
priosshrsth merged commit e98adfd into main Oct 7, 2026
8 checks passed

This branch was successfully deployed

1 active deployment
Preview — 4dbc8d24 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants