Repository navigation
OUT-3556 | Implement empty preview state when no clients exist - #227
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryAdds an empty state for previews without clients.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking inconsistency in how the empty state responds to the mobile and desktop preview controls. The initialization and empty-array handling are coherent, but the empty-client early return skips the display-mode-aware preview wrapper even though users can still change display modes. Files Needing Attention: src/features/editor/components/Preview/Preview.tsx Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Users or client context fetched] --> B[Populate users store]
B --> C[Set isInitialized]
C --> D{Clients available?}
D -->|No| E[Render EmptyClientPreview]
D -->|Yes| F[Render normal preview]
E --> G[Add clients action]
G --> H[Dashboard client-management page]
Reviews (1): Last reviewed commit: "fix(OUT-3556): implement empty preview s..." | Re-trigger Greptile |
|
|
||
| export const EmptyClientPreview = () => { | ||
| const handleAddClients = () => { | ||
| const dashboardOrigin = getDashboardOrigin() |
There was a problem hiding this comment.
I am hisitant with the implementatino of getDashboardOrigin. Are you sure it's reliable? What about window.parent or even getting workspace portal url which we should already have.
… the selector component
Changes
isInitializedstate which updates when users fetchers are completed.isInitializedis true and there are no clients.Testing Criteria