-
Notifications
You must be signed in to change notification settings - Fork 11
chore: add Bazel 8 testing #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94527dc
to
06f48e5
Compare
Revert WORKSPACE-only changes
Still two test failures. One of them is something trying to compile abseil-cpp from source, and we assert here that no functional CC toolchain should be required. I think it may be rules_python's fault though, rather than rules_proto or protobuf. |
Java protos still hit protocolbuffers/protobuf#19679, which hasn't been reviewed yet. But all other languages should work. |
Thanks, I'll try removing Java as well. |
The latest rules_proto has a fix to make this work, even though Bazel 8 moved the proto rule implementations to com_google_protobuf
Changes are visible to end-users: no
Test plan