fix(clippy): Store exit code to respect errors #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexeagle
approved these changes
Jan 12, 2026
blorente
force-pushed
the
blorente/keep-clippy-errors
branch
from
0b102d2 to
fd215b7
Compare
alexeagle
approved these changes
Jan 14, 2026
alexeagle
force-pushed
the
blorente/keep-clippy-errors
branch
from
4bbe6a1 to
44fefbd
Compare
# Conflicts: # example/test/BUILD.bazel # example/test/machine_outputs/BUILD.bazel # lint/clippy.bzl
alexeagle
force-pushed
the
blorente/keep-clippy-errors
branch
from
44fefbd to
1cb4c0d
Compare
alexeagle
added a commit
that referenced
this pull request
Jan 16, 2026
Clean up support for SARIF parsing in `//lint/rust`, and use it to transform the output of clippy into SARIF JSON reports. Depends on #707 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no (unless they were relying on the machine file to contain raw clippy diagnostics). - Suggested release notes appear below: no ### Test plan - New test cases added (and cleaned up the old ones) --------- Co-authored-by: Alex Eagle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume this change in rules_rust is going to merge, and take advantage of it to keep the clippy exit code in a file and avoid differentiating between warnings and errors.
Changes are visible to end-users: yes
Test plan