Skip to content

Commit 4bbe6a1

Browse files
committed
fixes
1 parent 31d90a0 commit 4bbe6a1

3 files changed

Lines changed: 7 additions & 20 deletions

File tree

.bazelrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ common --config=ruleset
44

55
# Don't build protoc from the cc_binary, it's slow and spammy when cache miss
66
common --incompatible_enable_proto_toolchain_resolution
7+
common --@protobuf//bazel/toolchains:prefer_prebuilt_protoc
78
common --per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
89
common --host_per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
910

.bcr/patches/go_dev_deps.patch

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
--- a/MODULE.bazel
22
+++ b/MODULE.bazel
3-
@@ -34,7 +34,7 @@ use_repo(multitool, "multitool")
4-
5-
# To allow /tools to be built from source
6-
# NOTE: when publishing to BCR, we patch this to be True, as we publish pre-built binaries with our releases.
3+
@@ -9,1 +9,1 @@
74
-IS_RELEASE = False
85
+IS_RELEASE = True
9-
10-
bazel_dep(
11-
name = "toolchains_protoc",

MODULE.bazel

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ module(
66
compatibility_level = 1,
77
)
88

9+
# NOTE: when publishing to BCR, we patch this to be True, as we publish pre-built binaries with our releases.
10+
IS_RELEASE = False
11+
912
# We don't actually depend directly on aspect_bazel_lib, but we do require this
1013
# version be used transitively so that it doesn't produce conflicting actions
1114
# with the bazel_lib module we use.
@@ -58,22 +61,11 @@ use_repo(rules_lint_toolchains, "sarif_parser_toolchains")
5861
register_toolchains("@sarif_parser_toolchains//:all")
5962

6063
####### Dev dependencies ########
61-
62-
bazel_dep(name = "bazelrc-preset.bzl", version = "1.1.0", dev_dependency = True)
63-
6464
# To allow /tools to be built from source
65-
# NOTE: when publishing to BCR, we patch this to be True, as we publish pre-built binaries with our releases.
66-
IS_RELEASE = False
67-
68-
bazel_dep(
69-
name = "toolchains_protoc",
70-
version = "0.6.0",
71-
dev_dependency = IS_RELEASE,
72-
)
7365

74-
protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc", dev_dependency = IS_RELEASE)
75-
protoc.toolchain(version = "v32.0")
66+
bazel_dep(name = "bazelrc-preset.bzl", version = "1.1.0", dev_dependency = True)
7667

68+
bazel_dep(name = "protobuf", version = "33.4", dev_dependency = IS_RELEASE)
7769
bazel_dep(
7870
name = "gazelle",
7971
version = "0.43.0",

0 commit comments

Comments
 (0)